[PATCH 1/1] Fix for timeout issues on U-Boot.

Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>

This is only a review for your benefit, since this would need to be
submitted to the u-boot mailing list to be accepted against the u-boot
or u-boot-arm git trees.

Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
---
cpu/arm_cortexa8/config.mk | 4 ++--
cpu/arm_cortexa8/omap3/config.mk | 2 +-
drivers/net/smc911x.c | 9 ++-------
include/configs/omap3_evm.h | 1 +
net/bootp.c | 10 +++++-----
net/net.c | 16 ++++++++--------
net/nfs.c | 6 +++---
net/rarp.c | 6 +++---
net/sntp.c | 4 ++--
net/tftp.c | 8 ++++----
10 files changed, 31 insertions(+), 35 deletions(-)

diff --git a/cpu/arm_cortexa8/config.mk b/cpu/arm_cortexa8/config.mk
index b021762..e8e1aaf 100644
--- a/cpu/arm_cortexa8/config.mk
+++ b/cpu/arm_cortexa8/config.mk
@@ -24,7 +24,7 @@ PLATFORM_RELFLAGS += -fno-strict-aliasing -fno-
common -ffixed-r8 \
         -msoft-float

# Make ARMv5 to allow more compilers to work, even though its v7a.
-PLATFORM_CPPFLAGS += -march=armv5
+PLATFORM_CPPFLAGS += -march=armv7a

Does this provide any real benefit? Does it really belong in the same
patch as fixing network support? At least fix the comment!!

#

=

======================================================================
#
# Supply options according to compiler version
@@ -33,4 +33,4 @@ PLATFORM_CPPFLAGS += -march=armv5
PLATFORM_CPPFLAGS +=$(call cc-option)
PLATFORM_CPPFLAGS +=$(call cc-option,-mno-thumb-interwork,)
PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,\
- $(call cc-option,-malignment-traps,))
\ No newline at end of file
+ $(call cc-option,-malignment-traps,))
diff --git a/cpu/arm_cortexa8/omap3/config.mk b/cpu/arm_cortexa8/
omap3/config.mk
index fbb753e..e8e1aaf 100644
--- a/cpu/arm_cortexa8/omap3/config.mk
+++ b/cpu/arm_cortexa8/omap3/config.mk
@@ -24,7 +24,7 @@ PLATFORM_RELFLAGS += -fno-strict-aliasing -fno-
common -ffixed-r8 \
         -msoft-float

# Make ARMv5 to allow more compilers to work, even though its v7a.
-PLATFORM_CPPFLAGS += -march=armv5
+PLATFORM_CPPFLAGS += -march=armv7a

Same comment as previous.

Jason Kridner wrote:

This is only a review for your benefit, since this would need to be
submitted to the u-boot mailing list to be accepted against the u-boot
or u-boot-arm git trees.

Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
---
cpu/arm_cortexa8/config.mk | 4 ++--
cpu/arm_cortexa8/omap3/config.mk | 2 +-
drivers/net/smc911x.c | 9 ++-------
include/configs/omap3_evm.h | 1 +
net/bootp.c | 10 +++++-----
net/net.c | 16 ++++++++--------
net/nfs.c | 6 +++---
net/rarp.c | 6 +++---
net/sntp.c | 4 ++--
net/tftp.c | 8 ++++----
10 files changed, 31 insertions(+), 35 deletions(-)

diff --git a/cpu/arm_cortexa8/config.mk b/cpu/arm_cortexa8/config.mk
index b021762..e8e1aaf 100644
--- a/cpu/arm_cortexa8/config.mk
+++ b/cpu/arm_cortexa8/config.mk
@@ -24,7 +24,7 @@ PLATFORM_RELFLAGS += -fno-strict-aliasing
-fno-common -ffixed-r8 \
             -msoft-float

# Make ARMv5 to allow more compilers to work, even though its v7a.
-PLATFORM_CPPFLAGS += -march=armv5
+PLATFORM_CPPFLAGS += -march=armv7a

Does this provide any real benefit? Does it really belong in the same
patch as fixing network support? At least fix the comment!!

For U-Boot mainline this is NACK. As the comment tells you, we spent
some work to make original TI U-Boot compile for armv5 as U-Boot
mainline toolchains don't know anything about armv7a. And as mentioned
by Jason, what is the benefit?

Dirk

Hi,

The build works for armv5 also. So this change is not required. While debugging the ethernet, between 2 versions
of uboot I came across an instruction ‘isb’ which was not supported on armv5.

regards
Manikandan Pillai