[PATCH] U-Boot V1: Beagle: Clean up nand.c

GoogleGroups
1

This patch cleans up nand.c of Steve's U-Boot for Beagle git tree [1] for future upstream sending. Hopefully no functional change,
just some clean up.

Signed-off-by: Dirk Behme <dirk.behme@gmail.com>

[1] http://www.sakoman.net/cgi-bin/gitweb.cgi?p=u-boot-omap3.git;a=shortlog;h=refs/heads/test

uboot_v1_beagle_steve_git_nand_patch.txt (10.4 KB)

2

Thanks for all the cleanup work! I really appreciate the help.

I pushed all of your patches this evening. I also merged with the
latest u-boot git:

http://www.sakoman.net/cgi-bin/gitweb.cgi?p=u-boot-omap3.git;a=shortlog;h=refs/heads/test

A trial build appears to work just fine :slight_smile:

On future patches it would make life a bit easier for me if you could
put the standard header info at the top of your patch file, i.e.
something like:

Clean up beagle clock code

Signed-off-by: Dirk Behme <dirk.be...@gmail.com>

3

sakoman wrote:

Thanks for all the cleanup work! I really appreciate the help.

I pushed all of your patches this evening.

Thanks for merging!

I also merged with the
latest u-boot git:

Do you have any hint how to get *one* complete beagle patch with the differences between mainline top and beagle top (i.e. between origin/master and origin/test)?

At the moment I create two trees, one with head origin/master and one with head origin/test and then manually do a diff -uprN between them.

On future patches it would make life a bit easier for me if you could
put the standard header info at the top of your patch file, i.e.
something like:

From: Dirk Behme <dirk.be...@gmail.com>

Clean up beagle clock code

Signed-off-by: Dirk Behme <dirk.be...@gmail.com>
---

That way its a simple one line "git am -3" for me to import the
patch :slight_smile:

Sure, no problem, will try this. Please complain if I fail :wink:

Thanks

Dirk

4

Dirk Behme wrote:

sakoman wrote:

Thanks for all the cleanup work! I really appreciate the help.

I pushed all of your patches this evening.

Thanks for merging!

I also merged with the
latest u-boot git:

Do you have any hint how to get *one* complete beagle patch with the
differences between mainline top and beagle top (i.e. between
origin/master and origin/test)?

git diff origin/master origin/test

At the moment I create two trees, one with head origin/master and one
with head origin/test and then manually do a diff -uprN between them.

On future patches it would make life a bit easier for me if you could
put the standard header info at the top of your patch file, i.e.
something like:

From: Dirk Behme <dirk.be...@gmail.com>

Clean up beagle clock code

Signed-off-by: Dirk Behme <dirk.be...@gmail.com>
---

That way its a simple one line "git am -3" for me to import the
patch :slight_smile:

Sure, no problem, will try this. Please complain if I fail :wink:

git-format-patch is your friend.

5

Do you have any hint how to get *one* complete beagle patch with the
differences between mainline top and beagle top (i.e. between origin/master
and origin/test)?

Yes. I do this all the time to generate a patch to use with my OE
recipe for u-boot. With the test branch checked out I do a:

git diff origin test > base.patch

and this seems to give me the right thing.

Thanks again!

Steve