[RFC] OMAP3 U-Boot v1 MUSB patch, please review

After Steve applied the sync patches and merged omap3-dev into omap3-dev-usb (thanks!), in attachment the diff between these two branches. Result is a ~37k U-Boot v1 MUSB patch we should clean up now.

Please review and comment.

Review comments should go as patches to omap3-dev-usb. With this, we will get a clean OMAP3 MUSB patch in omap3-dev-usb we can send to USB maintainer, later.

Note: Unfortunately, it doesn't apply to any upstream branch, yet. Upstream mainline has recent USB changes, but no OMAP3 (needed for config file changes), yet. Upstream u-boot-arm has OMAP3, but not recent USB changes.

Best regards

Dirk

Changed files:

drivers/serial/usbtty.h
drivers/usb/Makefile
drivers/usb/omap3530_usb.c
drivers/usb/omap3530_usb.h
drivers/usb/twl4030-usb.c
drivers/usb/usbdcore_musb.c
include/configs/omap3_beagle.h
include/configs/omap3_evm.h
include/usbdcore_musb.h
include/usb.h

u-boot-v1-omap3-usb-patch.txt (37 KB)

After Steve applied the sync patches and merged omap3-dev into
omap3-dev-usb (thanks!), in attachment the diff between these two
branches. Result is a ~37k U-Boot v1 MUSB patch we should clean up
now.

Please review and comment.

Review comments should go as patches to omap3-dev-usb. With this, we
will get a clean OMAP3 MUSB patch in omap3-dev-usb we can send to USB
maintainer, later.

I had not seen any note that [1], [2], and [3] had been applied, but
it appears are merged already on omap3-dev-usb. Were there any
changes made before applying those patches?

[1] http://groups.google.com/group/beagleboard/browse_thread/thread/3684dd45ba5cf190
[2] http://groups.google.com/group/beagleboard/browse_thread/thread/adbbab0be3b8eb62
[3] http://groups.google.com/group/beagleboard/browse_thread/thread/f230b4f8477bbb79

After Steve applied the sync patches and merged omap3-dev into
omap3-dev-usb (thanks!), in attachment the diff between these two
branches. Result is a ~37k U-Boot v1 MUSB patch we should clean up now.

Please review and comment.

Review comments should go as patches to omap3-dev-usb. With this, we
will get a clean OMAP3 MUSB patch in omap3-dev-usb we can send to USB
maintainer, later.

Note: Unfortunately, it doesn't apply to any upstream branch, yet.
Upstream mainline has recent USB changes, but no OMAP3 (needed for
config file changes), yet. Upstream u-boot-arm has OMAP3, but not
recent USB changes.

I was able to apply this by taking u-boot mainline and merging u-boot-arm. After applying the patch, I needed to also apply [1] before it could build.

By creating a gserial.inf based on the Linux kernel Documentation/usb/gadget_serial.txt, I was able to install a driver on Windows. I was then able to boot the Angstrom 2.6.28-r8 kernel. The USB gadget driver came up under the kernel as well.

It seems like the fastest possible you can get to the serial prompt in Windows is about 3 seconds, so bootdelay would need to be a minimum of 10 or so. I was able to easily work with the serial bootdelay set to only 1. The process for getting to the serial prompt quickly in Windows is tricky.

[1] http://www.sakoman.net/cgi-bin/gitweb.cgi?p=u-boot-omap3.git;a=commit;h=12536e347e55e4bc9c670dcc1d00e1f5e533f941