Error in am335x-pocketbeagle.dts

GoogleGroups
1

While testing a 7 Segment Click, I found an error in am335x-pocketbeagle.dts: The mode for P2_25 (SPI1 MOSI) should be 4 (spi1_d1), not 5 (spi1_cs0).

@@ -660,7 +660,7 @@

/* P2_25 (ZCZ ball E17) */
P2_25_default_pin: pinmux_P2_25_default_pin { pinctrl-single,pins = <

  • AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE5) >; }; /* uart0_rtsn.spi1_cs0 */
  • AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE4) >; }; /* uart0_rtsn.spi1_d1 /
    P2_25_gpio_pin: pinmux_P2_25_gpio_pin { pinctrl-single,pins = <
    AM33XX_IOPAD(0x096c, PIN_OUTPUT | INPUT_EN | MUX_MODE7) >; }; /     uart0_rtsn.gpio1_9 /
    P2_25_gpio_pu_pin: pinmux_P2_25_gpio_pu_pin { pinctrl-single,pins = <
    @@ -668,7 +668,7 @@
    P2_25_gpio_pd_pin: pinmux_P2_25_gpio_pd_pin { pinctrl-single,pins = <
    AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLDOWN | INPUT_EN | MUX_MODE7) >; }; /     uart0_rtsn.gpio1_9 */
    P2_25_spi_pin: pinmux_P2_25_spi_pin { pinctrl-single,pins = <
  • AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE5) >; }; /* uart0_rtsn.spi1_cs0 */
  • AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE4) >; }; /* uart0_rtsn.spi1_d1 /
    P2_25_i2c_pin: pinmux_P2_25_i2c_pin { pinctrl-single,pins = <
    AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE3) >; }; /     uart0_rtsn.I2C1_SCL */
    P2_25_uart_pin: pinmux_P2_25_uart_pin { pinctrl-single,pins = <
2

Hi Philip,

While testing a 7 Segment Click, I found an error in
am335x-pocketbeagle.dts: The mode for P2_25 (SPI1 MOSI) should be 4
(spi1_d1), not 5 (spi1_cs0).

@@ -660,7 +660,7 @@

  /* P2_25 (ZCZ ball E17) */
  P2_25_default_pin: pinmux_P2_25_default_pin { pinctrl-single,pins = <
- AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE5) >; }; /*
uart0_rtsn.spi1_cs0 */
+ AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE4) >; }; /*
uart0_rtsn.spi1_d1 */
  P2_25_gpio_pin: pinmux_P2_25_gpio_pin { pinctrl-single,pins = <
  AM33XX_IOPAD(0x096c, PIN_OUTPUT | INPUT_EN | MUX_MODE7) >; }; /*
uart0_rtsn.gpio1_9 */
  P2_25_gpio_pu_pin: pinmux_P2_25_gpio_pu_pin { pinctrl-single,pins = <
@@ -668,7 +668,7 @@
  P2_25_gpio_pd_pin: pinmux_P2_25_gpio_pd_pin { pinctrl-single,pins = <
  AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLDOWN | INPUT_EN | MUX_MODE7) >; }; /*
uart0_rtsn.gpio1_9 */
  P2_25_spi_pin: pinmux_P2_25_spi_pin { pinctrl-single,pins = <
- AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE5) >; }; /*
uart0_rtsn.spi1_cs0 */
+ AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE4) >; }; /*
uart0_rtsn.spi1_d1 */
  P2_25_i2c_pin: pinmux_P2_25_i2c_pin { pinctrl-single,pins = <
  AM33XX_IOPAD(0x096c, PIN_OUTPUT_PULLUP | INPUT_EN | MUX_MODE3) >; }; /*
uart0_rtsn.I2C1_SCL */
  P2_25_uart_pin: pinmux_P2_25_uart_pin { pinctrl-single,pins = <

Thanks for testing!

Just merged the same fix, just a moment ago..

"tools/pinmux-generator/PocketBeagle.dts"

https://github.com/beagleboard/bb.org-overlays/commit/ef1a508c7b6d84ab5e8051bed0850a0e41b51b79#diff-a306673b182b4b3570e3598007b6dcb0

I've split the "spi" to, spi, spi_cs, spi_sclk (and also brought the
can pins out)

i'll have updated 4.4.x/4.9.x/4.14.x-ti kernels out later today, with
this new default..

Regards,

3

here is a smaller diff, without all the pinmux-generator script:

https://github.com/RobertCNelson/dtb-rebuilder/commit/c423d1e19addd34b70a2725e72a605285e064886

Regards,