Patch[4/4]:This patch adds include directory for OMAP3

GoogleGroups
1

This patch adds include directory for OMAP3

Signed-off-by:
        Shashi Ranjan <shashiranjanmca05@gmail.com>
        Sunil Kumar <sunilsaini05@gmail.com>
        Syed Mohammed Khasim <khasim@ti.com>

2

Shouldn't the copyright date on these files include 2008?

Philip

3

All of the 34XX, LABRADOR, Virtio, and working comment mentions seem like they could serve to cause confusion. Can you remove stuff that isn't necessary? Is this code released by Richard elsewhere such that you simply wouldn't want to change it?

4

Thanks
Still many unnecessary things are left there which we have to remove.
we will do it soon..

5

sunil wrote:

Thanks
Still many unnecessary things are left there which we have to remove.
we will do it soon..

Okay, I will then have a closer look to the second series :wink: Didn't had time to look closer to the patches yet, but they apply cleanly to recent git :slight_smile:

While cleaning them, some hints regarding our goal to send them upstream:

- U-Boot list has a size limit of 40k, so you should split the patches in small, but reasonable parts.

- In Linux kernel script directory there is a nice script to automatically check patches for coding style conventions. Just do

<path_to_a_linux_kernel>/scripts/checkpatch <your_patch>

For upstream sending, there should be no errors/warnings any more.

- Please check the headers of all files. All TI copyrights should be 2008 and all files should contain a GPL note.

Jason: Yes, I think tabs are okay (or better "must"). As I understand it, this is kernel coding style, and u-boot uses the same.

Many thanks for the patches!

Dirk