Patch for doing error checking for onenand functions and adding the scrub and badblock commands on onenand patch (1/1)

GoogleGroups
1

Hi all,

Pls find a patch for onenand that fixes the problems related to parameter bound checks for onenand calls like read/write... This patch also adds the functions
for scrub and badblock - The support is similar to NAND device.

Pls let me know your comments.

Regards
Mani

u-boot-onnd-p2.txt (17.7 KB)

2

Mani,

Thanks for the patch submissions!

I will test this patch today and push if no problems.

Steve

3

Mani,

Pls find a patch for onenand that fixes the problems related to parameter bound checks for onenand calls like read/write... This patch also adds the functions
for scrub and badblock - The support is similar to NAND device.

Pls let me know your comments.

Unfortunately this patch does not apply cleanly. I think it assumes
that your previous onenand patch was applied.

See my previous comments on why that patch couldn't be applied. The
onenand offset issue has now been fixed upstream for all machines.

Could you combine the 'onenand erase block' portion of your previous
patch with this patch and resubmit?

Thanks!

Steve

4

Hi all,

I have combined the patches and trying to resubmit. This contains all the changes for onenand support into 1 patch.

To check that it does not break, I have applied to the latest download :
U-Boot 1.3.4-00565-g6b43fea-dirty (Aug 14 2008 - 09:44:13)

Pls let me know if you have any comments.

Regards
Mani

u-boot-onnd-consolidated-p1.txt (20.3 KB)

5

Mani,

Due to upstream changes in the mtd layer, your patch does not apply :frowning:

I broke out one portion that was board specific and applied it:

http://www.sakoman.net/cgi-bin/gitweb.cgi?p=u-boot-omap3.git;a=commit;h=d8107d69dc1d3650b6d2163ff6828b98ba6d9561

Unfortunately, you will need to regenerate the onenand patches
against the current head of the test branch.

Another side effect of the mtd upgrade is that the omap3evm nand
driver is broken. See the below checkin for details on what has
changed:

http://www.sakoman.net/cgi-bin/gitweb.cgi?p=u-boot-omap3.git;a=commit;h=cfa460adfdefcc30d104e1a9ee44994ee349bb7b

Since this change broke the evm build, I temporarily disabled nand on
the evm so that we can continue to build for onenand based evm's until
the nand driver is updated.

Beagle users should note that the above mentioned mtd change also
breaks the beagle u-boot build.

Only onenand based Overos and EVMs can use the current source tree successfully.

Regards,

Steve