[PATCH] Make fbset show correct timing values

GoogleGroups
1

Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>

2

Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
Cc: "Monk, Roger" <r-monk@ti.com>
---
Fixed fbset timings display issue for LCD patch:
http://groups.google.com/group/beagleboard/browse_thread/thread/4d6105c895e09152/b82883ca119ee053

1. Why do not you put that into the commit message?
2. You can also add that the same is done in `panel_generic.c`. Maybe
some header could be created to share these common functions?
3. What is the upstream status of this panel driver?

.../omap2/displays/panel-tfc-s9700rtwv35tr01b.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/drivers/video/omap2/displays/panel-tfc-s9700rtwv35tr01b.c b/drivers/video/omap2/displays/panel-tfc-s9700rtwv35tr01b.c
index c2a1a19..6afd4e3 100644
--- a/drivers/video/omap2/displays/panel-tfc-s9700rtwv35tr01b.c
+++ b/drivers/video/omap2/displays/panel-tfc-s9700rtwv35tr01b.c
@@ -88,6 +88,12 @@ static int tfc_panel_resume(struct omap_dss_device *dssdev)
   return tfc_panel_enable(dssdev);
}

+static void tfc_panel_get_timings(struct omap_dss_device *dssdev,
+ struct omap_video_timings *timings)
+{
+ *timings = dssdev->panel.timings;

Is the tabulator at the beginning enough?

+}
+
static struct omap_dss_driver tfc_s9700_driver = {
   .probe = tfc_panel_probe,
   .remove = tfc_panel_remove,
@@ -96,7 +102,7 @@ static struct omap_dss_driver tfc_s9700_driver = {
   .disable = tfc_panel_disable,
   .suspend = tfc_panel_suspend,
   .resume = tfc_panel_resume,
-
+ .get_timings = tfc_panel_get_timings,

Please align the »=« too.

   .driver = {
     .name = "tfc_s9700_panel",
     .owner = THIS_MODULE,

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>

Thanks,

Paul

3

Thanks Paul, I will incorporate your changes when I get to submitting a v2

thanks,
Joel

4

Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
Cc: "Monk, Roger" <r-monk@ti.com>
---

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>

Thanks Paul, I will incorporate your changes when I get to submitting a v2

The panel driver is not yet submitted, correct? I believe that is the
status. Once it is working reliably, it will be submitted. I think
what was forgotten to say here is that this driver is not yet working
and this is work-in-progress shared here for the purpose of
collaboration.