Hi Mani,
Pillai, Manikandan wrote:
Pls find the Patch 2/3 for support of Ethernet on OMAP3EVM.
You sent this patch two times. I did a diff, both mails seem to contain the same attachment. Is this correct or did you want to send the third patch instead?
I have reused the existing 911x source code for supporting the Ethernet rather than adding a new file.
Great! This makes the patch much smaller 
The tftp size has been changed back to 512 - After a tftp is done for the kernel
And/or filesystem the downloaded image does not work. (On diving more, I found that there are some memory corruptions at offsets of 0x4F8.)
Keep us up to date regarding this.
Pls send me your comments.
Same comment regarding checkpatch as for patch 1. See attachment. Yes, I agree, volatile and extern warnings we can ignore for now, but maybe you like to fix the other remaining warnings.
------------------------------------------------------------------------
From dbe9edd3cf156743c504674962da12265e3434fb Mon Sep 17 00:00:00 2001
From: Manikandan K Pillai <mani.pillai@ti.com>
Date: Fri, 25 Jul 2008 12:30:38 +0530
Subject: [PATCH] Patch to put in NET support for OMAP3 EVM - DEV_a0393249_OMAP3EVM_NET_PATCH
Signed-off-by: Manikandan K Pillai <mani.pillai@ti.com>
...
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 84be288..00bcf29 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -66,6 +66,7 @@ COBJS-$(CONFIG_ULI526X) += uli526x.o
COBJS-$(CONFIG_VSC7385_ENET) += vsc7385.o
COBJS-$(CONFIG_XILINX_EMAC) += xilinx_emac.o
COBJS-$(CONFIG_XILINX_EMACLITE) += xilinx_emaclite.o
+COBJS-$(CONFIG_DRIVER_SMC911X) += smc911x.o
COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
This rejects for me as my Makefile has an additional sh_ether after emaclite:
COBJS-$(CONFIG_XILINX_EMACLITE) += xilinx_emaclite.o
COBJS-$(CONFIG_SH_ETHER) += sh_eth.o
Dirk
checkpatch_p2.txt (10.2 KB)