[RFC][PATCH U-Boot v1] OMAP3: Add Beagle board revision detection

GoogleGroups
#1

Anybody with a Beagle revision C2 board likes to test patch in attachment and report output?

It adds revision detection as described in

http://groups.google.com/group/beagleboard/msg/ceb2751f9dde458f

to U-Boot v1 git head as in Steve's git.

In case of success I would remove debug output and send updated patch.

Many thanks

Dirk

On my old Beagle I get

-- cut --
U-Boot 2009.01-rc1 (Dez 30 2008 - 11:24:54)

OMAP3530-GP rev 2, CPU-OPP2 L3-165MHz
OMAP3 Beagle board + LPDDR/NAND
DRAM: 128 MB
NAND: 256 MiB
In: serial
Out: serial
Err: serial
Board revision: Ax/Bx
Debug (GPIO6 datain): 0x04801900
Hit any key to stop autoboot: 0
OMAP3 beagleboard.org #
-- cut --

u-boot-v1-beagle-revc2-detect.txt (4.76 KB)

#2

There are currently no C2 boards in existence. All we have are Rev C1 which do have the resistors in them.

Gerald

#3

Gerald Coley wrote:

There are currently no C2 boards in existence.

Well,

http://groups.google.com/group/beagleboard/msg/ceb2751f9dde458f

talked about Rev C2 :wink: I supposed C1 was just an other "try" and C2
would be the final one.

All we have are Rev C1
which do have the resistors in them.

Ok, Jason already fixed it :slight_smile:

http://www.beagleboard.org/gitweb/?p=u-boot-arm.git;a=blobdiff;f=board/omap3/beagle/beagle.c;h=7946e7c98b8fd959e838326db2c8d3d8bcb7c8de;hp=3f9939548159e2424603c55dd2e20b37f09af277;hb=3e11ac6c61d711adfa285cd48ae5a1666b0e7af5;hpb=3e27f686e8876bb2c25f46a12a4fd892a1c8becd

With "printf("Cx\n");" hopefully Koen won't complain that his C0 isn't
detected as rev Cx :wink:

Dirk

#4

Gerald Coley wrote:

There are currently no C2 boards in existence.

Well,

http://groups.google.com/group/beagleboard/msg/ceb2751f9dde458f

talked about Rev C2 :wink: I supposed C1 was just an other "try" and C2
would be the final one.

All we have are Rev C1
which do have the resistors in them.

Ok, Jason already fixed it :slight_smile:

http://www.beagleboard.org/gitweb/?p=u-boot-arm.git;a=blobdiff;f=board/omap3/beagle/beagle.c;h=7946e7c98b8fd959e838326db2c8d3d8bcb7c8de;hp=3f9939548159e2424603c55dd2e20b37f09af277;hb=3e11ac6c61d711adfa285cd48ae5a1666b0e7af5;hpb=3e27f686e8876bb2c25f46a12a4fd892a1c8becd

My Rev C1 is detected as a Rev Ax/Bx by this.

#5

Gerald,

Jason Kridner wrote:

Gerald Coley wrote:

There are currently no C2 boards in existence.

Well,

http://groups.google.com/group/beagleboard/msg/ceb2751f9dde458f

talked about Rev C2 :wink: I supposed C1 was just an other "try" and C2
would be the final one.

All we have are Rev C1
which do have the resistors in them.

Ok, Jason already fixed it :slight_smile:

http://www.beagleboard.org/gitweb/?p=u-boot-arm.git;a=blobdiff;f=board/omap3/beagle/beagle.c;h=7946e7c98b8fd959e838326db2c8d3d8bcb7c8de;hp=3f9939548159e2424603c55dd2e20b37f09af277;hb=3e11ac6c61d711adfa285cd48ae5a1666b0e7af5;hpb=3e27f686e8876bb2c25f46a12a4fd892a1c8becd

My Rev C1 is detected as a Rev Ax/Bx by this.

With Jason's Rev C1 GPIO module 6 data in register is

Debug (GPIO6 datain): 0x04801900

With this, my code assumes that GPIO_171 and GPIO_172 (GPIO6.11 and
GPIO6.12) are high and it reports Rev Ax/Bx.

Can you confirm that Jason's board has pull downs at GPIO6.11 and
GPIO6.12? And if yes, which mux config shall be used for GPIO6.11 and
GPIO6.12?

I used

MCSPI1_CLK: IEN | PTU | EN | M4 /* GPIO_171 */
MCSPI1_SIMO: IEN | PTU | EN | M4 /* GPIO_172 */

Thanks

Dirk

#6

Gerald,

Jason Kridner wrote:

Gerald Coley wrote:

There are currently no C2 boards in existence.

Well,

http://groups.google.com/group/beagleboard/msg/ceb2751f9dde458f

talked about Rev C2 :wink: I supposed C1 was just an other "try" and C2
would be the final one.

All we have are Rev C1
which do have the resistors in them.

Ok, Jason already fixed it :slight_smile:

http://www.beagleboard.org/gitweb/?p=u-boot-arm.git;a=blobdiff;f=board/omap3/beagle/beagle.c;h=7946e7c98b8fd959e838326db2c8d3d8bcb7c8de;hp=3f9939548159e2424603c55dd2e20b37f09af277;hb=3e11ac6c61d711adfa285cd48ae5a1666b0e7af5;hpb=3e27f686e8876bb2c25f46a12a4fd892a1c8becd

My Rev C1 is detected as a Rev Ax/Bx by this.

With Jason's Rev C1 GPIO module 6 data in register is

Debug (GPIO6 datain): 0x04801900

With this, my code assumes that GPIO_171 and GPIO_172 (GPIO6.11 and
GPIO6.12) are high and it reports Rev Ax/Bx.

Can you confirm that Jason's board has pull downs at GPIO6.11 and
GPIO6.12? And if yes, which mux config shall be used for GPIO6.11 and
GPIO6.12?

GPIO_172 is pulled down by R112, which is not populated on my board.
GPIO_171 is pulled down by R113, which I have not located on the board
yet.

#7

The pulldowns may be too small. I have not been able to look at this myself, but you can short the resisotrs out to give it a hard low.

Gerald

#8

GPIO_172 is pulled down by R112, which is not populated on my board.
GPIO_171 is pulled down by R113, which I have not located on the board yet.

I did a quick probe of R113 (GPIO171) and it is sitting around 0.9V (resistor must have similar size as internal pull-up). R112 (not populated) (GPIO172) is sitting around 1.8V.

Aside: I need to figure out how to get Apple's Mail.app to switch easily between rich text and plain text.

#9

Reminding me - What is preferred format for the mail group if any?
RTF/TXT/HTML?
  Søren

#10

Op 30 dec 2008, om 21:36 heeft Søren Steen Christensen het volgende geschreven:

Reminding me - What is preferred format for the mail group if any?
RTF/TXT/HTML?

Plain text, preferably utf8. Also, bottom posting is preferred to top-posting.

regards,

Koen

#11

Dirk Behme wrote:

Anybody with a Beagle revision C2 board likes to test patch in attachment and report output?

It adds revision detection as described in

http://groups.google.com/group/beagleboard/msg/ceb2751f9dde458f

to U-Boot v1 git head as in Steve's git.

In case of success I would remove debug output and send updated patch.

Many thanks

Dirk

On my old Beagle I get

-- cut --
U-Boot 2009.01-rc1 (Dez 30 2008 - 11:24:54)

OMAP3530-GP rev 2, CPU-OPP2 L3-165MHz
OMAP3 Beagle board + LPDDR/NAND
DRAM: 128 MB
NAND: 256 MiB
In: serial
Out: serial
Err: serial
Board revision: Ax/Bx
Debug (GPIO6 datain): 0x04801900
Hit any key to stop autoboot: 0
OMAP3 beagleboard.org #
-- cut --

Patch update against recent git after Beagle GPIO clean up patch. No other changes, we still need to verify if this works on rev C (stronger pull downs?).

Dirk

u-boot-v1-beagle-revc2-detect.txt (4.76 KB)

#12

Dirk Behme wrote:

Gerald,

Jason Kridner wrote:

Gerald Coley wrote:

There are currently no C2 boards in existence.

Well,

http://groups.google.com/group/beagleboard/msg/ceb2751f9dde458f

talked about Rev C2 :wink: I supposed C1 was just an other "try" and C2
would be the final one.

All we have are Rev C1
which do have the resistors in them.

Ok, Jason already fixed it :slight_smile:

http://www.beagleboard.org/gitweb/?p=u-boot-arm.git;a=blobdiff;f=board/omap3/beagle/beagle.c;h=7946e7c98b8fd959e838326db2c8d3d8bcb7c8de;hp=3f9939548159e2424603c55dd2e20b37f09af277;hb=3e11ac6c61d711adfa285cd48ae5a1666b0e7af5;hpb=3e27f686e8876bb2c25f46a12a4fd892a1c8becd

My Rev C1 is detected as a Rev Ax/Bx by this.

With Jason's Rev C1 GPIO module 6 data in register is

Debug (GPIO6 datain): 0x04801900

With this, my code assumes that GPIO_171 and GPIO_172 (GPIO6.11 and
GPIO6.12) are high and it reports Rev Ax/Bx.

Can you confirm that Jason's board has pull downs at GPIO6.11 and
GPIO6.12? And if yes, which mux config shall be used for GPIO6.11 and
GPIO6.12?

I used

MCSPI1_CLK: IEN | PTU | EN | M4 /* GPIO_171 */
MCSPI1_SIMO: IEN | PTU | EN | M4 /* GPIO_172 */

With Beagle Rev C1D I get

Debug (GPIO6 datain): 0x04801100

I.e. GPIO_171 (GPIO6.11) is low, but GPIO_172 (GPIO6.12) is still
high. This is better than having both pins high like with Jason's
device above, but still not both pins low.

Will this be changed for the final shipping boards? I.e. will they
have both pins low? Or shall we detect Rev C by GPIO_171 (GPIO6.11)
low, only, and ignore GPIO_172 (GPIO6.12)?

Thanks,

Dirk