[RFC] u-boot patches for REV C4

Khasim_Syed_Mohammed · January 5, 2010, 3:32pm

Hi all,

I am planning to submit these patches (excluding Dirk's REV detection
patch) to u-boot list. Can you please give your comments and
suggestions.

These patches will add
- I2C bus switching logic
- Support to enable 720 Mhz ARM MPU clock on REV C4 boards
- Enables DSS for background on DVI-D and color bar on S-video with
out using FRAMEBUFFERs
- Rev Detection patch from Dirk.

Will send mails with Inline patches as well.

Regards
Khasim

0001-OMAP3-Beagle-Update-revision-detection.patch (3.98 KB)

0002-Configure-PRCM-registers-to-support-720-Mhz-on-Beagl.patch (3.29 KB)

0003-Configure-DSS-to-enable-DVI-D-and-S-Video.patch (4.23 KB)

0004-Enable-I2C-bus-switching.patch (1.25 KB)

Khasim_Syed_Mohammed · January 5, 2010, 3:41pm

Kindly NOTE, these patches will apply on top of

http://git.denx.de/u-boot-ti.git
git://git.denx.de/u-boot-ti.git

http://git.denx.de/?p=u-boot/u-boot-ti.git;a=summary

Regards,
Khasim

Syed_Mohammed_Khasi1 · January 6, 2010, 2:25pm

FYI,

I have submitted these patches to u-boot mailing list. Received
comments for PRCM patch, have re-submitted after incorporating review
comments.

Regards,
Khasim

Nishanth_Menon · January 6, 2010, 2:29pm

FYI,

I have submitted these patches to u-boot mailing list. Received
comments for PRCM patch, have re-submitted after incorporating review
comments.

Could you keep the discussion in beagle board OR on u-boot ML? it is a
bit confusing to have discussions in two different places.

Syed_Mohammed_Khasi1 · January 6, 2010, 2:35pm

It is just FYI on beagle mailing list, all discussions about patches
are supposed to happen on u-boot mailing list.

May be I can keep beagle mailing list in CC, will do that next time.

Regards,
Khasim

jkridner · January 8, 2010, 12:48pm

FYI,

I have submitted these patches to u-boot mailing list. Received
comments for PRCM patch, have re-submitted after incorporating review
comments.

Could you keep the discussion in beagle board OR on u-boot ML? it is a
bit confusing to have discussions in two different places.

It is just FYI on beagle mailing list, all discussions about patches
are supposed to happen on u-boot mailing list.

May be I can keep beagle mailing list in CC, will do that next time.

Yeah, cross-posting makes the most sense to me.

Favor_Tang · January 12, 2010, 9:17am

Hi, when I build u-boot, these patches caused errors. what’ the problem is? and please show me how to solve this.

thanks.

NOTE: Running task 6241 of 6331 (ID: 151, /home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb, do_patch)
NOTE: Running task 6247 of 6331 (ID: 134, /home/user/Beagle/OE/openembedded/recipes/mtd/mtd-utils-native_1.2.0+git.bb, do_configure)
NOTE: Applying patch ‘new-pinmux.patch’ (openembedded/recipes/u-boot/u-boot-git/new-pinmux.patch)
NOTE: Applying patch ‘revision-detection.patch’ (openembedded/recipes/u-boot/u-boot-git/beagleboard/revision-detection.patch)
ERROR: Error in executing: /home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb
ERROR: Exception:<class ‘CmdError’> Message:Command Error: exit status: 1 Output:
Applying patch revision-detection.patch
patching file board/ti/beagle/beagle.c
patch: **** malformed patch at line 106:

Patch revision-detection.patch does not apply (enforce with -f)
ERROR: Printing the environment of the function
ERROR: Error in executing: /home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb
ERROR: Exception:<class ‘CmdError’> Message:Command Error: exit status: 1 Output:
Applying patch revision-detection.patch
patching file board/ti/beagle/beagle.c
patch: **** malformed patch at line 106:

Patch revision-detection.patch does not apply (enforce with -f)
ERROR: Printing the environment of the function
ERROR: Build of /home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb do_patch failed
Traceback (most recent call last):
File “/home/user/Beagle/OE/bitbake/bin/bitbake”, line 143, in
main()
File “/home/user/Beagle/OE/bitbake/bin/bitbake”, line 140, in main
cooker.cook()
File “/home/user/Beagle/OE/bitbake/lib/bb/cooker.py”, line 640, in cook
return self.buildTargets(pkgs_to_build)
File “/home/user/Beagle/OE/bitbake/lib/bb/cooker.py”, line 547, in buildTargets
failures = rq.execute_runqueue()
File “/home/user/Beagle/OE/bitbake/lib/bb/runqueue.py”, line 841, in execute_runqueue
self.execute_runqueue_internal()
File “/home/user/Beagle/OE/bitbake/lib/bb/runqueue.py”, line 950, in execute_runqueue_internal
self.cooker.tryBuild(fn)
File “/home/user/Beagle/OE/bitbake/lib/bb/cooker.py”, line 136, in tryBuild
return self.tryBuildPackage(fn, item, self.configuration.cmd, the_data)
File “/home/user/Beagle/OE/bitbake/lib/bb/cooker.py”, line 110, in tryBuildPackage
bb.build.exec_task(‘do_%s’ % task, the_data)
File “/home/user/Beagle/OE/bitbake/lib/bb/build.py”, line 283, in exec_task
exec_func(task, localdata)
File “/home/user/Beagle/OE/bitbake/lib/bb/build.py”, line 120, in exec_func
exec_func_python(func, d)
File “/home/user/Beagle/OE/bitbake/lib/bb/build.py”, line 141, in exec_func_python
utils.better_exec(comp, g, tmp, bbfile)
File “/home/user/Beagle/OE/bitbake/lib/bb/utils.py”, line 185, in better_exec
exec code in context
File “do_patch”, line 4, in
File “do_patch”, line 2, in do_patch
File “/home/user/Beagle/OE/bitbake/lib/bb/build.py”, line 120, in exec_func
exec_func_python(func, d)
File “/home/user/Beagle/OE/bitbake/lib/bb/build.py”, line 141, in exec_func_python
utils.better_exec(comp, g, tmp, bbfile)
File “/home/user/Beagle/OE/bitbake/lib/bb/utils.py”, line 185, in better_exec
exec code in context
File “base_do_patch”, line 4, in
File “base_do_patch”, line 2, in base_do_patch
File “/home/user/Beagle/OE/bitbake/lib/bb/build.py”, line 120, in exec_func
exec_func_python(func, d)
File “/home/user/Beagle/OE/bitbake/lib/bb/build.py”, line 141, in exec_func_python
utils.better_exec(comp, g, tmp, bbfile)
File “/home/user/Beagle/OE/bitbake/lib/bb/utils.py”, line 185, in better_exec
exec code in context
File “patch_do_patch”, line 98, in
File “patch_do_patch”, line 96, in patch_do_patch
File “”, line 361, in Resolve
builtin.CmdError: Command Error: exit status: 1 Output:
Applying patch revision-detection.patch
patching file board/ti/beagle/beagle.c
patch: **** malformed patch at line 106:

Patch revision-detection.patch does not apply (enforce with -f)
NOTE: Running task 6248 of 6331 (ID: 135, /home/user/Beagle/OE/openembedded/recipes/mtd/mtd-utils-native_1.2.0+git.bb, do_qa_configure)
ERROR: Task 151 (/home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb, do_patch) failed
NOTE: Waiting for 1 active tasks to finish
NOTE: 1: /home/user/Beagle/OE/openembedded/recipes/mtd/mtd-utils-native_1.2.0+git.bb, do_qa_configure (21795)
NOTE: Tasks Summary: Attempted 6246 tasks of which 6245 didn’t need to be rerun and 1 failed.
ERROR: ‘/home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb’ failed

H_Nikolaus_Schaller · January 12, 2010, 9:43am

For me patching worked (by using -p1 flag)

2 ideas:
a) patch file encoding after download (crlf problem)
b) did you not apply patch to git://git.denx.de/u-boot-ti.git

Favor_Tang · January 13, 2010, 3:29am

hi,

it’s problem of “crlf”. I download these patches via “git pull” from openembedded repo.
others may meet this problem like me, I hope someone would note this and will fix this in OE.

thanks