TI:OMAP: [PATCH 1/7] OMAP3 Beagle Update revision detection

GoogleGroups
1

From 2dce4d64339a26144eac2ed56eb664cc1ea527c7 Mon Sep 17 00:00:00 2001

2

Khasim Syed Mohammed wrote:

From 2dce4d64339a26144eac2ed56eb664cc1ea527c7 Mon Sep 17 00:00:00 2001
From: Syed Mohammed Khasim <khasim@ti.com>
Date: Mon, 18 Jan 2010 18:03:42 +0530
Subject: [PATCH] OMAP3 Beagle Update revision detection

New BeagleBoard revision C4 uses a new ID. Update revision detection.

This patch set caused regressions in MAKEALL arm
These must be fixed.

omap3_beagle
cmd_i2c.c:109: warning: missing braces around initializer
cmd_i2c.c:109: warning: (near initialization for 'i2c_no_probes[0]')
beagle.c: In function 'misc_init_r':
beagle.c:143: warning: implicit declaration of function 'twl4030_pmrecv_vsel_cfg'
beagle.c:152: warning: implicit declaration of function 'prcm_config_720mhz'

The changes I asked from for 1/7 were done.
Tom

3

Khasim Syed Mohammed wrote:

From 2dce4d64339a26144eac2ed56eb664cc1ea527c7 Mon Sep 17 00:00:00 2001

Khasim: The 'From' line of your patch starts with an additional '>'

>From 2dce4d64339a2 ...

Could you check where this comes from? Maybe this confuses the mailing list archive

http://lists.denx.de/pipermail/u-boot/2010-January/066629.html

?

And could you try to add a 'vX' version to the subject of your patches? E.g.

[PATCH 1/7 v4] OMAP3 Bea ....

This would really help to identify the patch versions.

From: Syed Mohammed Khasim<khasim@ti.com>
Date: Mon, 18 Jan 2010 18:03:42 +0530
Subject: [PATCH] OMAP3 Beagle Update revision detection

New BeagleBoard revision C4 uses a new ID. Update revision detection.

This patch set caused regressions in MAKEALL arm

Tom: On recent master a84b655fab2bc021fdafa91d1196cf826474cdd8 this patch seems to compile fine (?)

Best regards

Dirk

4

[…]

And could you try to add a 'vX' version to the subject of your
patches? E.g.

[PATCH 1/7 v4] OMAP3 Bea ....

This would really help to identify the patch versions.

Just for your information, because it is not that obvious. You can
achieve this when running `git format-patch` by using
`--subject-prefix="PATCH v4"` (for example, see `git help
format-patch`).

[…]

Thanks and I wish Khasim luck that the next series is going to be the
last iteration,

Paul

5

Dear Dirk Behme,

6

Khasim Syed Mohammed wrote:

From 2dce4d64339a26144eac2ed56eb664cc1ea527c7 Mon Sep 17 00:00:00 2001
From: Syed Mohammed Khasim<khasim@ti.com>
Date: Mon, 18 Jan 2010 18:03:42 +0530
Subject: [PATCH] OMAP3 Beagle Update revision detection

New BeagleBoard revision C4 uses a new ID. Update revision detection.

This patch set caused regressions in MAKEALL arm
These must be fixed.

omap3_beagle
cmd_i2c.c:109: warning: missing braces around initializer
cmd_i2c.c:109: warning: (near initialization for 'i2c_no_probes[0]')
beagle.c: In function 'misc_init_r':
beagle.c:143: warning: implicit declaration of function 'twl4030_pmrecv_vsel_cfg'
beagle.c:152: warning: implicit declaration of function 'prcm_config_720mhz'

With recent U-Boot main git head "a1b322a98319de568b3bc38029ef7e123643c1e8" I don't see this:

> ./MAKEALL omap3_beagle
Configuring for omap3_beagle board...
    text data bss dec hex filename
  184267 9764 202428 396459 60cab ./u-boot

--------------------- SUMMARY ----------------------------
Boards compiled: 1